Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load visual editor on new pages #708

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: load visual editor on new pages #708

merged 2 commits into from
Dec 18, 2024

Conversation

leandrocp
Copy link
Contributor

@leandrocp leandrocp commented Dec 17, 2024 •
edited
Loading

Beacon.Content.get_page/2 fails since there's no page saved yet. This PR also simplified a few things:

  • Simplify the build of a new @beacon assign
  • Make the arguments more explicit
  • Remove the source arg so callers don't need to be responsible for how the assign is built

@leandrocp
fix: load visual editor on new pages
8a6ccde 
`Beacon.Content.get_page/2` fails since there's no page saved yet.
leandrocp added a commit to BeaconCMS/beacon_live_admin that referenced this pull request Dec 17, 2024
@leandrocp
fix new
96cece3 
depends on BeaconCMS/beacon#708
@leandrocp leandrocp mentioned this pull request Dec 17, 2024
Open
@leandrocp
rework @beacon assign
a1f003e 
- remove the need to pass around the source
- simplify building it
@leandrocp leandrocp marked this pull request as ready for review December 18, 2024 18:13
@leandrocp leandrocp requested a review from APB9785 December 18, 2024 18:14
APB9785
APB9785 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@APB9785 APB9785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice improvement to infer the published status from id: nil instead of having the caller pass in a source 🚀

@leandrocp leandrocp merged commit 681ad3e into main Dec 18, 2024
3 checks passed
@leandrocp leandrocp deleted the lp-fix-visual-editor-new branch December 18, 2024 18:50
leandrocp added a commit to BeaconCMS/beacon_live_admin that referenced this pull request Dec 20, 2024
@leandrocp
fix: beacon assigns call
73f5c91 
ref: BeaconCMS/beacon#708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APB9785 APB9785 APB9785 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrocp @APB9785